-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Rector in CI and process the entire project #214
Conversation
$batch = 0; | ||
foreach ($events as $event) { | ||
$this->em->delete($event); | ||
|
||
if ($batch++ % $batchSize === 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
???
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably there was batch deletion. I want to refactor this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$batch++ % $batchSize === 0
is always true. It should be like: ++$batch % $batchSize === 0
@@ -58,10 +57,6 @@ private function handlePipeline(ServerRequestInterface $request): ResponseInterf | |||
\assert($handler instanceof HandlerInterface); | |||
$this->position++; | |||
|
|||
if ($handler === null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
\assert($handler instanceof HandlerInterface);
already do type check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I see, $handler can be null, so it's better to fix assertion
@@ -29,7 +29,7 @@ final class HtmlDumper extends CliDumper | |||
|
|||
public function __construct(DumpIdGeneratorInterface $generator) | |||
{ | |||
AbstractDumper::__construct(null, null, 0); | |||
AbstractDumper::__construct(null, null, 0); // CliDumper? parent?? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, AbstractDumper
app/modules/Profiler/Interfaces/Queries/FindTopFunctionsByUuidHandler.php
Show resolved
Hide resolved
Cool, Thx for a great work! |
No description provided.